This worklog has been replaced with mariadb.org/jira

This site is here for historical purposes only. Do not add or edit tasks here!

 
 
 

WorkLog Frontpage Log in / Register
High-Level Description | Task Dependencies | High-Level Specification | Low-Level Design | File Attachments | User Comments | Time Estimates | Funding and Votes | Progress Reports

 Backport key cache to 5.0
Title
Task ID52
Queue
Version
Status
Priority
Copies toSanja

Created bySanja27 Aug 2009Done
Supervisor   
Lead Architect    
Architecture Review  
Implementor  
Code Review  
QA  
Documentation  
 High-Level Description
Backport keycache to bring bugfixes made in 5.1.
 Task Dependencies
Others waiting for Task 52Task 52 is waiting forGraph
 
 High-Level Specification
Backport keycache to 5.0
 Low-Level Design
Here is instructions of how to repeat this if needed:

- Copy the following files from the latest MySQL 5.1 to MySQL 5.0:

include/keycache.h
include/my_bit.h
mysys/mf_keycache.c
mysys/mf_keycaches.c
mysys/my_bit.c

Apply the following change in mysys/mf_keycaches.c
81c81
< static uchar *safe_hash_entry_get(SAFE_HASH_ENTRY *entry, size_t *length,
---
> static uchar *safe_hash_entry_get(SAFE_HASH_ENTRY *entry, uint *length,

recompile everything.

Simple test to verify that this is working:
cd mysql-test
mysql-test-run --valgrind key_cache
(the --valgrind argument can be left out if you don't have valgrind installed)
 File Attachments
 NameTypeSizeByDate
 User Comments
 Time Estimates
NameHours WorkedLast Updated
Guest627 Aug 2009
Sanja301 Sep 2009
Total9 
 Hrs WorkedProgressCurrentOriginal
This Task908
Total908
 
 Funding and Votes
Votes: 0: 0%
 Make vote: Useless    Nice to have    Important    Very important    

Funding: 0 offers, total 0 Euro
 Progress Reports
(Sanja - Tue, 01 Sep 2009, 15:18
    
testing Monty's patch
Worked 3 hours and estimate 0 hours remain (original estimate increased by 1 hour).

(Guest - Fri, 28 Aug 2009, 10:55
    
Low Level Design modified.
--- /tmp/wklog.52.old.16945	2009-08-28 10:55:40.000000000 +0300
+++ /tmp/wklog.52.new.16945	2009-08-28 10:55:40.000000000 +0300
@@ -1 +1,22 @@
-Just copy files (mf_keycache.c & key=cache.h) and fix what should be fixed.
+Here is instructions of how to repeat this if needed:
+
+- Copy the following files from the latest MySQL 5.1 to MySQL 5.0:
+
+include/keycache.h
+include/my_bit.h
+mysys/mf_keycache.c
+mysys/mf_keycaches.c
+mysys/my_bit.c
+
+Apply the following change in mysys/mf_keycaches.c
+81c81
+< static uchar *safe_hash_entry_get(SAFE_HASH_ENTRY *entry, size_t *length,
+---
+> static uchar *safe_hash_entry_get(SAFE_HASH_ENTRY *entry, uint *length,
+
+recompile everything.
+
+Simple test to verify that this is working:
+cd mysql-test
+mysql-test-run --valgrind key_cache
+(the --valgrind argument can be left out if you don't have valgrind installed)

(Guest - Thu, 27 Aug 2009, 21:52
    
- Planning code (Email dicussions & discussions with Sanja): 2 hours.
- Backport of code (2 hours). Notice that mysys/mf_keycaches.c::safe_hash_entry_get() is different
from the code in MySQL 5.1
- Testing code with mysql-test-run (especially running the key_cache.test with valgrind)
- Tested the server with sql-bench
Worked 6 hours and estimate 2 hours remain (original estimate unchanged).

(Sanja - Thu, 27 Aug 2009, 09:56
    
High-Level Specification modified.
--- /tmp/wklog.52.old.20094	2009-08-27 09:56:05.000000000 +0300
+++ /tmp/wklog.52.new.20094	2009-08-27 09:56:05.000000000 +0300
@@ -1 +1 @@
-
+Backport keycache to 5.0

(Sanja - Thu, 27 Aug 2009, 09:55
    
Low Level Design modified.
--- /tmp/wklog.52.old.20035	2009-08-27 09:55:25.000000000 +0300
+++ /tmp/wklog.52.new.20035	2009-08-27 09:55:25.000000000 +0300
@@ -1 +1 @@
-
+Just copy files (mf_keycache.c & key=cache.h) and fix what should be fixed.


Report Generator:
 
Saved Reports:

WorkLog v4.0.0
  © 2010  Sergei Golubchik and Monty Program AB
  © 2004  Andrew Sweger <yDNA@perlocity.org> and Addnorya
  © 2003  Matt Wagner <matt@mysql.com> and MySQL AB